CRITICAL FIX: chat.py had TWO execution paths causing inconsistent behavior:
1. Tool calling (correct) - used centralized command_patterns
2. Legacy JSON command parsing (broken) - bypassed SysadminTools
This caused macha-chat to fail SSH connections while macha-ask worked.
Changes:
- Rewrote chat.py to use ONLY tool-calling architecture
- All commands now go through SysadminTools.execute_command()
- SSH commands use centralized command_patterns.py
- conversation.py is now a lightweight wrapper for compatibility
- Both macha-chat and macha-ask use the same code path
- Updated module.nix to call chat.py directly
Benefits:
- Consistent behavior between macha-chat and macha-ask
- Single execution path = easier to maintain
- All SSH commands use explicit key paths
- No more password prompts
Fixes:
- SSH from macha-chat now works correctly
- Both interfaces use centralized command patterns
CRITICAL: Prevents inconsistent sudo/SSH patterns across codebase.
Created command_patterns.py with:
- Single source of truth for ALL command execution patterns
- SSH key path constant: /var/lib/macha/.ssh/id_ed25519
- Remote user constant: macha
- sudo prefix for all remote commands
- Helper functions: build_ssh_command(), transform_ssh_command()
- Self-validation tests
Updated files to use centralized patterns:
- tools.py: Uses transform_ssh_command()
- remote_monitor.py: Uses build_ssh_command()
- system_discovery.py: Uses build_ssh_command()
- DESIGN.md: Documents centralized approach
Benefits:
- Impossible to have inconsistent patterns
- Single place to update if needed
- Self-documenting with validation tests
- Prevents future refactoring errors
DO NOT duplicate these patterns in other files - always import.
CRITICAL FIX: SSH keys were not being auto-loaded, causing connection failures.
Changes:
- tools.py: SSH commands now include -i /var/lib/macha/.ssh/id_ed25519
- remote_monitor.py: Use explicit key path instead of sudo ssh
- system_discovery.py: Added explicit key path to all SSH calls
- system_prompt.txt: Document automatic SSH key loading
- DESIGN.md: Clarify CRITICAL requirement for explicit key paths
All SSH operations now explicitly specify:
-i /var/lib/macha/.ssh/id_ed25519 -o StrictHostKeyChecking=no
This ensures Macha can reliably connect to remote hosts without
depending on SSH agent or automatic key discovery.
Macha is now a standalone NixOS flake that can be imported into other
systems. This provides:
- Independent versioning
- Easier reusability
- Cleaner separation of concerns
- Better development workflow
Includes:
- Complete autonomous system code
- NixOS module with full configuration options
- Queue-based architecture with priority system
- Chunked map-reduce for large outputs
- ChromaDB knowledge base
- Tool calling system
- Multi-host SSH management
- Gotify notification integration
All capabilities from DESIGN.md are preserved.
