Implement robust logging with flexi_logger and update CI to verify logs

.gitea/workflows/smoke-tests.yml

@@ -179,24 +179,37 @@ jobs:
             exit 1
           fi
           
+          MS_LOG=$(ls -t logs/mudserver_*.log 2>/dev/null | head -n 1)
+          CB_LOG=$(ls -t logs/combat_*.log 2>/dev/null | head -n 1)
+          
           FAILED=0
           
-          echo "Checking mudserver logs..."
-          grep -q "World '.*': .* rooms" logs/mudserver_*.log || { echo "Failed: World loading log missing"; FAILED=1; }
-          grep -q "MUD server listening on" logs/mudserver_*.log || { echo "Failed: Listen log missing"; FAILED=1; }
-          grep -q "New character created: smoketest" logs/mudserver_*.log || { echo "Failed: smoketest creation log missing"; FAILED=1; }
-          grep -q "Admin action: registration setting updated: '.*'" logs/mudserver_*.log || { echo "Failed: Admin action log missing"; FAILED=1; }
+          if [ -z "$MS_LOG" ]; then
+            echo "Error: no mudserver log files found"
+            FAILED=1
+          else
+            echo "Checking mudserver log: $MS_LOG"
+            grep -q "World '.*': .* rooms" "$MS_LOG" || { echo "Failed: World loading log missing"; FAILED=1; }
+            grep -q "MUD server listening on" "$MS_LOG" || { echo "Failed: Listen log missing"; FAILED=1; }
+            grep -q "New character created: smoketest" "$MS_LOG" || { echo "Failed: smoketest creation log missing"; FAILED=1; }
+            grep -q "Admin action: registration setting updated: '.*'" "$MS_LOG" || { echo "Failed: Admin action log missing"; FAILED=1; }
+          fi
           
-          echo "Checking combat logs..."
-          grep -q "Combat: Player 'smoketest' (ID .*) engaged NPC 'Shadowy Thief'" logs/combat_*.log || { echo "Failed: Combat engagement log missing"; FAILED=1; }
-          grep -q "Combat: Player 'smoketest' (ID .*) killed NPC 'Shadowy Thief'" logs/combat_*.log || { echo "Failed: NPC kill log missing"; FAILED=1; }
+          if [ -z "$CB_LOG" ]; then
+            echo "Error: no combat log files found"
+            FAILED=1
+          else
+            echo "Checking combat log: $CB_LOG"
+            grep -q "Combat: Player 'smoketest' (ID .*) engaged NPC 'Shadowy Thief'" "$CB_LOG" || { echo "Failed: Combat engagement log missing"; FAILED=1; }
+            grep -q "Combat: Player 'smoketest' (ID .*) killed NPC 'Shadowy Thief'" "$CB_LOG" || { echo "Failed: NPC kill log missing"; FAILED=1; }
+          fi
           
           if [ $FAILED -ne 0 ]; then
             echo "--- LOG VERIFICATION FAILED ---"
             echo "--- MUDSERVER LOG CONTENTS ---"
-            cat logs/mudserver_*.log
+            [ -n "$MS_LOG" ] && cat "$MS_LOG"
             echo "--- COMBAT LOG CONTENTS ---"
-            cat logs/combat_*.log
+            [ -n "$CB_LOG" ] && cat "$CB_LOG"
             exit 1
           fi
           echo "Logging verification passed."

src/main.rs

@@ -92,7 +92,6 @@ async fn main() {
             Naming::Numbers,
             Cleanup::KeepLogFiles(7),
         )
-        .append()
         .write_mode(WriteMode::Direct)
         .try_build()
         .unwrap();
@@ -100,7 +99,6 @@ async fn main() {
     Logger::try_with_str(&log_level)
         .unwrap()
         .log_to_file(FileSpec::default().directory(&log_dir).basename("mudserver"))
-        .append()
         .duplicate_to_stderr(Duplicate::All)
         .rotate(
             Criterion::Size(10_000_000), // 10 MB